Skip to content

Fix tiny int handling #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix tiny int handling #252

wants to merge 3 commits into from

Conversation

thelonelyvulpes
Copy link

@thelonelyvulpes thelonelyvulpes commented Jul 25, 2025 •
edited
Loading

fixes #164 by casting the small i8s to i8 before casting to i64 to avoid the sign being ignored.
coauthor: @robsdedude

madchicken
madchicken approved these changes Aug 3, 2025
View reviewed changes
Copy link
Collaborator

@madchicken madchicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modification makes sense and seems to solve the issue

@madchicken madchicken requested a review from knutwalker August 3, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madchicken madchicken madchicken approved these changes

@knutwalker knutwalker Awaiting requested review from knutwalker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bolt integer coming back wrong?
2 participants
@thelonelyvulpes @madchicken