Remove single relationships #5819
Open
+2,552
−21,511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4f3f45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
angrykoala
force-pushed
the
remove-single-relationship
branch
from
d6e4024
to
ed732e2
Compare
angrykoala
force-pushed
the
remove-single-relationship
branch
from
3444c9c
to
f4f3f45
Compare
MacondoExpress
approved these changes
Nov 20, 2024
| @@ -176,6 +176,7 @@ export function createRelationshipFields({ | |||
| userDefinedFieldDirectivesForNode: Map<string, Map<string, DirectiveNode[]>>; | |||
| features?: Neo4jFeaturesSettings; | |||
| }): void { | |||
| // HERE? | |||
There was a problem hiding this comment.
Suggested change
| // HERE? |
| const isList = Boolean(getListTypeNode(field)); | ||
|
|
||
| if (isRelationship && !isList) { | ||
| console.warn( |
There was a problem hiding this comment.
I would change this to be a validation rule, so that an error is raised before reaching make-augmented-schema
| type ${typePost} @node { | ||
| id: String | ||
| content: String | ||
| creator: ${typeUser}! @relationship(type: "HAS_POST", direction: IN) |
There was a problem hiding this comment.
Is this test no longer necessary?
| type ${typePost} @node { | ||
| id: String | ||
| content: String | ||
| creator: ${typeUser}! @relationship(type: "HAS_POST", direction: IN) |
There was a problem hiding this comment.
Same as above, is there is any reason to delete this test rather than change the creator type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes 1-1 relationships