Closed
Conversation
ConorNeo
reviewed
Apr 4, 2023
bigmontz
commented
Apr 4, 2023
| "test": "jest", | ||
| "test::watch": "jest --watch", | ||
| "test::unit": "npm run test", | ||
| "test::deno": "deno test --allow-none ./test/deno/", |
Contributor
Author
There was a problem hiding this comment.
It might worth to remove the flag --allow-none after you create testing code under ./test/deno/.
Core features which are environment dependent will need to be implemented. For testing this features, environment dependent tests need to be setup. The `deno` tests can be run by `npm run test::deno` and they need to be located under `./packages/core/test/deno`. The testkit pipeline is configured to run these tests only when configured for test `deno`.
bigmontz
force-pushed
the
5.x-enable-tests-in-core-deno
branch
from
72b8636 to
4579f14
Compare
Contributor
|
The idea is good but the changes here are out of date and small, so it'll be easier to start from scratch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core features which are environment dependent will need to be implemented. For testing this features, environment dependent tests need to be setup.
The
denotests can be run bynpm run test::denoand they need to be located under./packages/core/test/deno. The testkit pipeline is configured to run these tests only when configured for testdeno.