Add directories list #114
Open
Add directories list #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomasprime
force-pushed
the
add-directories-list
branch
3 times, most recently
from
415d314 to
0e5aee0
Compare
nomasprime
force-pushed
the
add-directories-list
branch
from
0e5aee0 to
23940aa
Compare
Contributor
Author
|
Should mention I've only tested this with ripgrep. |
kidonng
reviewed
May 11, 2021
|
|
||
| class Task extends FilesTask { | ||
| protected post_process_hook(process: ChildProcess) { | ||
| let post_process = spawn('sh', ['-c', 'xargs -I {} gdirname {} | sort | uniq']) |
Contributor
There was a problem hiding this comment.
You can use sort --unique instead of sort | uniq. But isn't there better ways than spawning another shell?
Contributor
Author
There was a problem hiding this comment.
Thanks @kidonng. I've noticed it's very slow on larger projects. Hopefully I'll have time to improve it soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.