-
-
Notifications
You must be signed in to change notification settings - Fork 5
Added library for zip transforms #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Last commit published: f90d67fefc07830382d9f5b71f921f7913affcab - version: PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name = "Maven for PR #23" // https://github.com/neoforged/InstallerTools/pull/23
url = uri("https://prmaven.neoforged.net/InstallerTools/pr23")
content {
includeModule("net.neoforged.installertools", "binarypatcher")
includeModule("net.neoforged.installertools", "cli-utils")
includeModule("net.neoforged.installertools", "installertools")
includeModule("net.neoforged.installertools", "jarsplitter")
includeModule("net.neoforged.installertools", "problems-api")
includeModule("net.neoforged.installertools", "zipinject")
includeModule("net.neoforged.installertools", "ziptransform")
}
}
} |
| @@ -1,5 +1,7 @@ | |||
| dependencies { | |||
| implementation 'net.neoforged.gradleutils:net.neoforged.gradleutils.gradle.plugin:5.0.0' | |||
| implementation 'org.ow2.asm:asm:9.7' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't asm on 9.8 already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but we're compiling with JDK8 here. (I didn't actually check what the minimum java version for apache compress is hmmm).
edit Okay, Apache Compress also says "The current release requires Java 8 or above."
|
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
No description provided.