Skip to content

Conversation

@shartte
Copy link
Contributor

@shartte shartte commented Jul 19, 2025

No description provided.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 19, 2025

  • Publish PR to GitHub Packages

Last commit published: f90d67fefc07830382d9f5b71f921f7913affcab - version: 3.0.24

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name = "Maven for PR #23" // https://github.com/neoforged/InstallerTools/pull/23
        url = uri("https://prmaven.neoforged.net/InstallerTools/pr23")
        content {
            includeModule("net.neoforged.installertools", "binarypatcher")
            includeModule("net.neoforged.installertools", "cli-utils")
            includeModule("net.neoforged.installertools", "installertools")
            includeModule("net.neoforged.installertools", "jarsplitter")
            includeModule("net.neoforged.installertools", "problems-api")
            includeModule("net.neoforged.installertools", "zipinject")
            includeModule("net.neoforged.installertools", "ziptransform")
        }
    }
}

@@ -1,5 +1,7 @@
dependencies {
implementation 'net.neoforged.gradleutils:net.neoforged.gradleutils.gradle.plugin:5.0.0'
implementation 'org.ow2.asm:asm:9.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't asm on 9.8 already?

Copy link
Contributor Author

@shartte shartte Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but we're compiling with JDK8 here. (I didn't actually check what the minimum java version for apache compress is hmmm).

edit Okay, Apache Compress also says "The current release requires Java 8 or above."

@neoforged-automation
Copy link

@shartte, this pull request has conflicts, please resolve them for this PR to move forward.

@neoforged-automation neoforged-automation bot added the needs rebase This Pull Request needs to be rebased before being merged label Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebase This Pull Request needs to be rebased before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants