[WIP] Lazily configure dependency configurations #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lukebemish
reviewed
Apr 23, 2025
| var java = (AdhocComponentWithVariants) project.getComponents().getByName("java"); | ||
| java.addVariantsFromConfiguration(elementsConfiguration, variant -> { | ||
| // TODO: no better way? | ||
| java.addVariantsFromConfiguration(elementsConfiguration.get(), variant -> { |
Contributor
There was a problem hiding this comment.
Use project.getComponents().named(...) to make this lazy
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
neoforged-automation
bot
added
the
needs rebase
neoforged-automation
bot
removed
the
needs rebase
|
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
neoforged-automation
bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickly thrown together, needs cleaning up and testing. The goal here is to move to lazy configuration of
Configurations, which will be applicable starting from Gradle 8.14.I wonder if there would be a way to detect all cases of eager
Configurationconfiguration, to make sure that this PR is doing what it advertises.