Implement the ability to use a binary patched Jar instead of running NeoForm. #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
neoforged-automation
bot
added
the
needs rebase
|
@shartte, this pull request has conflicts, please resolve them for this PR to move forward. |
Technici4n
reviewed
Nov 6, 2025
|
|
||
| // Download version manifest | ||
| HttpRequest manifestRequest = HttpRequest.newBuilder() | ||
| .uri(URI.create("https://piston-meta.mojang.com/mc/game/version_manifest_v2.json")) |
Member
There was a problem hiding this comment.
It would be great to cache this. Imagine you are in a train and suddenly Gradle decides to re-run this task for whatever reason. That might be an argument to use NFRT :P
Technici4n
reviewed
Nov 6, 2025
| import java.util.zip.ZipFile; | ||
|
|
||
| /** | ||
| * Sourced from the userdev config json. The run templates are the only thing that we use. |
Member
There was a problem hiding this comment.
This comment needs an update. :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.