neonvm-controller: set MigrationName on a VM #1300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No changes to the coverage.
HTML Report |
olegbbtr
changed the title
Signed-off-by: Oleg Vasilev <[email protected]>
This allows us to resolve conflicts between different migrations trying to work with the same VM. Signed-off-by: Oleg Vasilev <[email protected]>
Not a functional change, makes code simpler. Signed-off-by: Oleg Vasilev <[email protected]>
olegbbtr
force-pushed
the
oleg/05-migration-logic
branch
from
8b31e33 to
8479225
Compare
sharnoff
reviewed
Mar 7, 2025
| } | ||
| return &vm, nil | ||
| // return err and try reconcile again | ||
| return ctrl.Result{}, err |
Contributor
There was a problem hiding this comment.
question(blocking): Given that if err != nil always ends in returning here, does that mean that we never remove the finalizer, and so the migration object cannot be deleted if the VM doesn't exist?
Contributor
Author
There was a problem hiding this comment.
That's true, and this problem existed before this PR. Let me think about a solution.
| return r.updateMigrationStatus(ctx, migration) | ||
| if vm.Status.MigrationName == "" { | ||
| if vm.Status.Phase != vmv1.VmRunning { | ||
| // VM must be scaling, so we will try again in a second |
Contributor
There was a problem hiding this comment.
question:
VM must be scaling
Why?
Contributor
Author
There was a problem hiding this comment.
That's an evolution of the // some other VM status (Scaling may be), requeue after second
But I agree, "may be" should not have turned into must be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to: