neonvm-controller: Improve usage of finalizer methods #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controllerutil.AddFinalizer/RemoveFinalizer are made to be idempotent, and return whether or not any changes were made. We can use that in our logic around adding / removing finalizers to simplify things. This encompasses two small changes: 1. Don't check `ContainsFinalizer` before adding - just try to add it, and persist the update if it was actually changed. 2. If `RemoveFinalizer` doesn't change the object, treat this as an unexpected error!
Omrigan
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controllerutil.AddFinalizer/RemoveFinalizerare made to be idempotent, and return whether or not any changes were made. We can use that in our logic around adding / removing finalizers to simplify things.This encompasses two small changes:
ContainsFinalizerbefore adding — just try to add it, and persist the update if it was actually changed.RemoveFinalizerdoesn't change the object, treat this as an unexpected error!