Skip to content

Conversation

@bayandin
Copy link
Contributor

@bayandin bayandin commented Jan 13, 2025

We don't use statically linked OpenSSL anymore (#10302),
it's ok to switch to Neon's pgbench for pgvector benchmarks

@bayandin bayandin requested a review from Bodobolero January 13, 2025 14:39
Copy link
Contributor

@Bodobolero Bodobolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care

@github-actions
Copy link

github-actions bot commented Jan 13, 2025

7414 tests run: 7063 passed, 0 failed, 351 skipped (full report)


Flaky tests (7)

Postgres 17

Code coverage* (full report)

  • functions: 33.4% (8509 of 25499 functions)
  • lines: 49.1% (71462 of 145505 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4ddd681 at 2025-01-30T09:41:41.782Z :recycle:

@bayandin bayandin marked this pull request as ready for review January 13, 2025 17:37
@bayandin bayandin requested a review from a team as a code owner January 13, 2025 17:37
@bayandin bayandin marked this pull request as draft January 13, 2025 17:38
@bayandin
Copy link
Contributor Author

We can merge this PR after the next storage release.
Currently, the latest version of Neon artifacts points to the version with still statically linked OpenSSL and pgbench still fail:

@bayandin bayandin force-pushed the bayandin/use-neons-pgbench branch from 3366d6b to 9ed7378 Compare January 27, 2025 21:20
@bayandin bayandin force-pushed the bayandin/use-neons-pgbench branch from 9ed7378 to 4ddd681 Compare January 30, 2025 08:39
@bayandin
Copy link
Contributor Author

bayandin commented Jan 30, 2025

Running it again: https://github.com/neondatabase/neon/actions/runs/13048547685

UPD: Tests have passed!

@bayandin bayandin marked this pull request as ready for review January 30, 2025 10:51
@bayandin bayandin changed the title Use Neon's pgbench for pgvector benchmarks Nightly Benchmarks: Use Neon's pgbench Jan 30, 2025
@bayandin bayandin changed the title Nightly Benchmarks: Use Neon's pgbench Nightly Benchmarks: use pgbench from artifacts Jan 30, 2025
@bayandin bayandin enabled auto-merge January 30, 2025 10:56
@bayandin bayandin added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 8804d58 Jan 30, 2025
110 checks passed
@bayandin bayandin deleted the bayandin/use-neons-pgbench branch January 30, 2025 11:19
winter-loo pushed a commit to winter-loo/neon that referenced this pull request Feb 4, 2025
We don't use statically linked OpenSSL anymore (neondatabase#10302), 
it's ok to switch to Neon's pgbench for pgvector benchmarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants