Skip to content

fix(test): use the same value for reldir v1+v2 #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 3, 2025

Problem

part of #11067

#9516

My observation is that with the current value of settings, x86-v1 usually takes 30s, arm-v1 1m30s, x86-v2 1m, arm-v2 3m. But sometimes the system could run too slow and cause test to timeout on arm with reldir v2.

While I investigate what's going on and further improve the performance, I'd like to set both of them to use the same test input, so that it doesn't timeout and we don't abuse this test case as a performance test.

Summary of changes

Use the same settings for both test cases.

@skyzh skyzh requested a review from alexanderlaw March 3, 2025 20:28
Copy link

github-actions bot commented Mar 3, 2025

7788 tests run: 7410 passed, 0 failed, 378 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 32.9% (8677 of 26390 functions)
  • lines: 48.8% (73902 of 151415 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6d83f7a at 2025-03-03T21:28:45.362Z :recycle:

@alexanderlaw
Copy link
Contributor

I've run "Build and Test with Sanitizers" against this branch and got much better timing for this test on ARM:
https://neon-github-public-dev.s3.amazonaws.com/reports/branch-skyzh-tune-relv2-test/13648665473/index.html#suites/158be07438eb5188d40b466b6acfaeb3/419408c26b1ebca4/
[release-pg17-v1], Duration: 2m 25s

https://neon-github-public-dev.s3.amazonaws.com/reports/branch-skyzh-tune-relv2-test/13648665473/index.html#suites/158be07438eb5188d40b466b6acfaeb3/8267a75bb212efed/
[release-pg17-v2], Duration: 1m 20s

For reference, the nightly run of the same workflow against main shows:
https://neon-github-public-dev.s3.amazonaws.com/reports/main/13644198179/index.html#suites/158be07438eb5188d40b466b6acfaeb3/7e9349d6ccb880eb/
[release-pg17-v1], Duration: 1m 49s

https://neon-github-public-dev.s3.amazonaws.com/reports/main/13644198179/index.html#suites/158be07438eb5188d40b466b6acfaeb3/ebbd164ec7b079af/
[release-pg17-v2], Duration: 4m 47s

That is, the duration of v2 decreased as expected, the change looks good to me.

@skyzh skyzh added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 20af9ce Mar 4, 2025
109 checks passed
@skyzh skyzh deleted the skyzh/tune-relv2-test branch March 4, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants