refactor(compaction): rename skip_some to add and update implementation #12831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for key additionChanges: - Replace CompactionKey::skip_some() with add(offset: u32) - Update Key implementation to use new add() method - Update simulator mock implementation - Update call site in compact_tiered.rs to explicitly pass 128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the
CompactionKeytrait to replaceskip_some()withadd(u32), addressing the FIXME comment inpageserver/compaction/src/interface.rs:114.Changes
skip_some()method withadd(offset: u32)inCompactionKeytraitadd()methodadd(128)Motivation
The previous
skip_some()method was inflexible - it advanced by a hardcoded amount that implementors couldn'tcontrol. The FIXME comment noted "why not just add(u32)? This is hard to use."
This change makes the API more flexible by allowing callers to specify exactly how much to advance, making the
intent clearer at call sites.