Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI versions #37

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Update CI versions #37

merged 6 commits into from
Jan 21, 2025

Conversation

conradludgate
Copy link

Update CI versions to latest (see #36). Also updates rust version and adds the Cargo.lock so that rust-version shouldn't matter in future.

fedordikarev
fedordikarev approved these changes Jan 20, 2025
View reviewed changes
Copy link

@fedordikarev fedordikarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Although I have very limited knowledge of Rust, so can't review rust changes properly.
Either "if it's fine for linter and it compiles, it's fine for me", or if someone else with Rust knowledge could review, it will be good

@conradludgate conradludgate merged commit 547812b into neon Jan 21, 2025
6 checks passed
@conradludgate conradludgate deleted the conrad/fix-ci branch January 21, 2025 13:01
@fedordikarev fedordikarev mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@problame problame problame approved these changes

@fedordikarev fedordikarev fedordikarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conradludgate @problame @fedordikarev @ds-cbo