TASK: Introduce PHP code linting / refactoring and fix affected code #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After deployment this change first needs to be migrated with ``` ./flow nodemigration:execute 20250623134952 ``` Then remove the deprecated childnodes with ``` ./flow structureadjustments:fix —node-type Neos.MarketPlace:Version ```
This was referenced Jun 24, 2025
mhsdesign
reviewed
Jun 25, 2025
bwaidelich
reviewed
Jun 25, 2025
DistributionPackages/Neos.NeosConIo/Classes/Eel/FlowQueryOperations/SortMultipleOperation.php
Outdated
Show resolved
Hide resolved
DistributionPackages/Neos.NeosConIo/Classes/Eel/FlowQueryOperations/SortMultipleOperation.php
Show resolved
Hide resolved
DistributionPackages/Neos.NeosIo/Classes/Service/CrowdApiConnector.php
Outdated
Show resolved
Hide resolved
bootstrap-phpstan.php
Outdated
There was a problem hiding this comment.
I don't understand this. Isn't the root problem, that we are missing an explicit dependency on neos/media (or rather neos/neos?) even though we are using classes of those namespaces?
There was a problem hiding this comment.
I'm not quite sure.@mhsdesign fixed it like this in the core and I copied the file.
DistributionPackages/Neos.NeosIo/Classes/Fusion/FlowQueryOperations/CrowdGroupsOperation.php
Show resolved
Hide resolved
DistributionPackages/Neos.NeosIo/Classes/Fusion/FlowQueryOperations/CrowdGroupsOperation.php
Outdated
Show resolved
Hide resolved
DistributionPackages/Neos.NeosIo/Classes/Fusion/FlowQueryOperations/CrowdUserOperation.php
Outdated
Show resolved
Hide resolved
Sebobo
changed the title
FEATURE: Simplify marketplace structure
|
dammit I accidentally already merged the marketplace refactoring in here |
|
Nevermind. Let's just fix composer.lock and get this merged! |
|
Linting of the migration will be separately solved with Sebobo/Shel.Neos.Schema#29 |
|
Yaml is now also linting fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeType and configuration schema linting
PHPStan level 8