-
Notifications
You must be signed in to change notification settings - Fork 488
Batchify all APIs #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batchify all APIs #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from skimming through it! I'll take a closer look later
benchmark batch feature with 10000 gaussians (
|
Hey cool pr. Does this also work with bilateral grid? Is distributed computing (Grendel) supported? |
Hey there! This is just to update the bilateral grid already supports arbitrary batching on the final rendered images -- so yes it works with bilateral grid. For Grendel, we already supported it in gsplat -- you could training a single scene with multiple GPUs by distributing the GSs. This PR addresses batching over multiple scenes (for the use cases of those feed-forward models) which is not quite relevant / orthogonal to Grendel. |
Ok, got it! Thank you! |
0518.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome job JC for such huge effort!
Fix bug in this video. gsplat-batch.mp4 |
This PR updated all the existing APIs (3DGS, 2DGS, 3DGUT) to support multiple batch dimensions eg. [A, B, C] -> [..., A, B, C], which
ensures backward compatibility.
is tested with various batch dimension configurations.