Popup image depth compositing #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oded turtle example
|
This diff has a ton of new _icons files, not sure where they came from @brentyi |
…ser into justin/nerf_depth_compositing
brentyi
reviewed
Aug 14, 2023
brentyi
force-pushed
the
justin/nerf_depth_compositing
branch
from
99856db
to
2df6999
Compare
brentyi
force-pushed
the
justin/nerf_depth_compositing
branch
from
2df6999
to
a005977
Compare
brentyi
approved these changes
Aug 25, 2023
yzslab
pushed a commit
to yzslab/viser
that referenced
this pull request
Oct 20, 2024
* very early WIP of depth compositing shader, sort of works for a hardcoded turtle example * fix texture sampling logic with vertex shader * improvements * GUI container refactor * Clean up panel display, still some kinks to work out * working depth compositing, need to clean up/document things * Improve expanded panel behavior; drag regression for mobile view * Fix toggle for sidebar display * Fix type * refactor for popup img instead of background_image * add enabled flag to texture * bad merge * 4 byte packing * more work * working float passing? * works! * Remove icons : ) * Revert SMPL-X example * remove depth scale * cleanup * make popup example * comment * garbage collect old textures, repackage PopupImage into BackgroundImage * Update compositing example * More precision * Nits, type errors * Nits * Use 3 bytes, fix mypy/ruff * Naming --------- Co-authored-by: Brent Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for an RGBD image which floats in front of the camera, useful for compositing NeRF in 3D with other 3js objects.