Send connection types to NervesHub #118
Open
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhunleth
reviewed
Mar 21, 2023
|
It crashes the socket if we send a message like this to NervesHub servers that don't support it. But since you have to call it in your own code, is it fine to leave as a note in the docs for |
Adds a callback to let the device have a hook for knowing that its connected successfully to nerves hub. This allows sending connection types up the socket after fully connected. Connection types are "ethernet", "wifi", "cellular".
oestrich
force-pushed
the
connection-types
branch
from
7f143f5 to
66a85a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a callback to let the device have a hook for knowing that its connected successfully to nerves hub. This allows sending connection types up the socket after fully connected. Connection types are "ethernet", "wifi", "cellular".
There is a matching PR for Nerves Hub to save this information.