Add foundational support for multiple Sockets to be started #360
+69
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshk
force-pushed
the
allow-for-multiple-sockets-to-run
branch
from
ebdbd0e to
fbe7b9e
Compare
jjcarstens
reviewed
Oct 28, 2025
Comment on lines
+45
to
49
| @spec reconnect!(GenServer.server()) :: :ok | ||
| def reconnect!(server \\ __MODULE__) do | ||
| GenServer.cast(server, :reconnect) | ||
| end |
There was a problem hiding this comment.
Why change to a ! function? The trailing bang idiom usually denotes the function will succeed or raise. In this case, it is a cast which will always return :ok
There was a problem hiding this comment.
Same issue as Connor mentioned, there already exists a reconnect function and defining a new one makes elixir unhappy.
We can call it something else, suggestions welcome. Since Socket isn’t publicly documented, we can use whatever name we want.
There was a problem hiding this comment.
Ooo! Right, I had forgotten about that. The use macro strikes again!
This seems fine. I don't have any better name ideas for now
joshk
force-pushed
the
allow-for-multiple-sockets-to-run
branch
from
fbe7b9e to
46cd4c9
Compare
jjcarstens
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #127