Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove the capsule and cross #107

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

mohanson
Copy link
Collaborator

  • Completely remove the capsule and cross.
  • Upgraded clang to clang-18. Since capsule and its docker environment is removed, you must install clang-18 or riscv64-unknown-elf-gcc locally.

contracts/spawn-caller/Cargo.toml Outdated Show resolved Hide resolved
test/Makefile Show resolved Hide resolved
test/src/contract.rs Show resolved Hide resolved
contracts/spawn-caller/Cargo.toml Outdated Show resolved Hide resolved
@XuJiandong
Copy link
Collaborator

fix warnings:

warning: unused variable: `err`
   --> /Users/xxx/projects/ckb-std/src/high_level.rs:569:17
    |
569 |             Err(err) => {
    |                 ^^^ help: if this is intentional, prefix it with an underscore: `_err`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `ckb-std` (lib) generated 1 warning (run `cargo fix --lib -p ckb-std` to apply 1 suggestion)
   Compiling simulator v0.1.0 (/Users/xxx/projects/ckb-std/test/simulator)
warning: unused variable: `v`
  --> src/../../../contracts/ckb-std-tests/src/entry.rs:34:9
   |
34 |     let v = vec![0u8; 42];
   |         ^ help: if this is intentional, prefix it with an underscore: `_v`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `data_hash`
   --> src/../../../contracts/ckb-std-tests/src/entry.rs:157:9
    |
157 |     let data_hash = packed::CellOutput::calc_data_hash(&data);
    |         ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_data_hash`

warning: `simulator` (bin "contract") generated 2 warnings (run `cargo fix --bin "contract"` to apply 2 suggestions)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 00s

@mohanson
Copy link
Collaborator Author

These warnings have been there since these PRs:

e544f02

22648e2

@XuJiandong XuJiandong merged commit aaffc73 into nervosnetwork:master Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants