-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Type ID implementation #108
Conversation
native simulator must have std enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is fine but I'm confused here, it really seems to me that this PR mixes type ID logic with other non-type-id changes together. In the future it would be best if we can split non-related changes to multiple PRs.
It really seems to me that a different workflow is used here:
If this different workflow is used, it should be clearly noted in the PR title / description. |
type-id