Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: data2 value #4093

Merged

Conversation

zhangsoledad
Copy link
Member

What is changed and how it works?

The hash type is split into the high 7 bits and the low 1 bit, when the low 1 bit is 1, it indicates the type, when the low 1 bit is 0, it indicates the data, and then it relies on the high 7 bits to indicate that the data actually corresponds to the version.
So data2 should be 4.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

None: Exclude this PR from the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner August 9, 2023 08:51
@zhangsoledad zhangsoledad requested review from doitian and removed request for a team August 9, 2023 08:51
@eval-exec eval-exec added the hotfix Fixing that must be submit to RC branch. label Aug 9, 2023
@eval-exec
Copy link
Collaborator

CI action failed, this PR need re-execute make gen-rpc-doc.

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix-data2 branch 2 times, most recently from 2e4b3eb to 6d9b838 Compare August 9, 2023 15:16
@zhangsoledad zhangsoledad added this pull request to the merge queue Aug 10, 2023
Merged via the queue into nervosnetwork:develop with commit cd8aebf Aug 10, 2023
34 checks passed
@zhangsoledad zhangsoledad deleted the zhangsoledad/fix-data2 branch August 16, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Fixing that must be submit to RC branch.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants