Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix vm version select #4218

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: fix vm version select #4218

merged 1 commit into from
Nov 6, 2023

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Nov 2, 2023 •
edited
Loading

What problem does this PR solve?

  1. During synchronization, 2019 version transactions should use the v0 version of the VM
  2. rpc should faithfully represent the epoch in which the 2021 hardfork is located(just VM relations)
  3. cycles due to wrong version vm will be reset to None(migration will on another pr)

Check List

Tests

  • Unit test
  • Integration test

Release note

Note: Add a note under the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner November 2, 2023 03:35
@eval-exec eval-exec added p:should-have Priority: important but not necessary for delivery in the current delivery timebox hotfix Fixing that must be submit to RC branch. b:consensus Break consensus and removed p:should-have Priority: important but not necessary for delivery in the current delivery timebox hotfix Fixing that must be submit to RC branch. labels Nov 2, 2023
zhangsoledad
zhangsoledad reviewed Nov 2, 2023
View reviewed changes
rpc/README.md Outdated Show resolved Hide resolved
zhangsoledad
zhangsoledad requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@zhangsoledad zhangsoledad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really support setting cycles to 0, 0 is too vague, we would have used Option, if not it's None, if not None , Cycles should be an exact value. why 0？

@driftluo driftluo force-pushed the fix-vm-version-select branch 3 times, most recently from 5e79a45 to bd97284 Compare November 2, 2023 09:22
@zhangsoledad zhangsoledad self-requested a review November 3, 2023 03:46
@zhangsoledad zhangsoledad added this pull request to the merge queue Nov 6, 2023
Merged via the queue into nervosnetwork:develop with commit 413f2af Nov 6, 2023
32 checks passed
@driftluo driftluo deleted the fix-vm-version-select branch November 6, 2023 09:51
@chenyukang chenyukang mentioned this pull request Nov 9, 2023
Merged
@doitian doitian mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec left review comments

@yangby-cryptape yangby-cryptape yangby-cryptape approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake Awaiting requested review from quake

@xxuejie xxuejie Awaiting requested review from xxuejie

Assignees
No one assigned
Labels
b:consensus Break consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driftluo @zhangsoledad @yangby-cryptape @eval-exec