refactor: replace bash-based e2e test runner with Python script#973
Closed
doitian wants to merge 2 commits intonervosnetwork:developfrom
Closed
refactor: replace bash-based e2e test runner with Python script#973doitian wants to merge 2 commits intonervosnetwork:developfrom
doitian wants to merge 2 commits intonervosnetwork:developfrom
Conversation
Updated the retry wait time from 30 seconds to 10 seconds when the port file is not found, improving the responsiveness of the script.
The new Python script automates running e2e tests in the background, allowing you to "fire and forget" while you continue working. The script provides better process management, cleanup, and local debugging capabilities while matching the behavior of the GitHub Actions workflow.
Collaborator
|
I'm not sure whether it's better to maintain, after all it's 551 new lines code added and only 18 lines deleted, i prefer to shorter code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the bash-based e2e test runner in the GitHub Actions workflow with a comprehensive Python script that provides better error handling, process management, and maintainability.
Changes
New Python E2E Test Runner (
tests/bruno/e2e/run_e2e_local.py)GitHub Actions Workflow Simplification
.github/workflows/e2e.ymlto call the Python script instead of inline bash commandsMinor Fix
tests/nodes/wait.shfrom 30 seconds to 10 seconds for faster feedbackBenefits
Testing
The script maintains the same behavior as the previous bash-based approach and works with all existing e2e workflows:
3-nodes-transfercross-chain-hubfunding-tx-verificationudt