Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cqrs): Added configurable event bus example #1995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bradsheppard
Copy link

@bradsheppard bradsheppard commented Aug 4, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Docs
  • Other... Please describe:

What is the current behavior?

Documentation lacks examples on how to use IEventPublisher and IMessageSource as implemented in nestjs/cqrs#12.

Issue Number: #1239

What is the new behavior?

Update documentation which provides an example on how to implement IEventPublisher and IMessageSource.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@darvesh
Copy link

darvesh commented Oct 13, 2021

Can this be merged? :)

@bradsheppard
Copy link
Author

@darvesh Hopefully soon :P

@kamilmysliwiec Do you think its worth adding this? If not I can close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants