Add Expose decorator to all fields on Pagination class #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I use:
excludeExtraneousValues: true
is a secure practice that enforces the use of explicit@Expose()
fromclass-transformer
on every property that should be exposed on an API, thus eliminating any way to implicitly expose any field via HTTP.This project-wide option is incompatible with
nestjs-typeorm-paginate
as@Expose()
is missing on thePagination
class. I added it with no drawbacks for developers who don't use that option.Looks like I made large edits to lock files; feel free to commit on my fork if you believe there's anything to fix on that front.