Skip to content

Support custom SSL certificates for the dashboard #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

benniekiss
Copy link

This PR refactors the init_cert.sh script in the docker container to support using custom SSL certificates.

I've added two env-vars, NGINX_SSL_CERT and NGINX_SSL_KEY, which when set, will configure the nginx default.conf with the provided port and certificate paths. When LETSENCRYPT_DOMAIN is set, NGINX_SSL_CERT and NGINX_SSL_KEY are ignored.

I've also made it so that the dashboard port can be changed without providing certificates. This way, setting NGINX_SSL_PORT will change the nginx listen port. It may be worth considering changing the env-var name.

This partially closes netbirdio/netbird#2242

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

@benniekiss
Copy link
Author

Force-pushed to fix authorship

@iammuho
Copy link

iammuho commented Nov 7, 2024

When that PR will be merged ?

@johnnypea
Copy link

Is this going to be merged anytime soon, please?

@benniekiss
Copy link
Author

This PR needs updated to match the correct format for the http2 directive. I'll try to get to that when I can, but I've since moved to a custom dashboard container, so this is not really on my priority list.

@benniekiss
Copy link
Author

I've updated the http2 directive and updated the alpine version (it was very very old!). I haven't run any tests since I do not use the regular dashboard container in my deployment anymore, so if a community member wants to test and ensure this works, please do! I believe it should.

@bcmmbaga @mlsmaycon this is ready for review if you are interested in taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom ssl certificates for all services
4 participants