-
Notifications
You must be signed in to change notification settings - Fork 78
Support custom SSL certificates for the dashboard #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Force-pushed to fix authorship |
When that PR will be merged ? |
Is this going to be merged anytime soon, please? |
This PR needs updated to match the correct format for the |
I've updated the @bcmmbaga @mlsmaycon this is ready for review if you are interested in taking a look. |
This PR refactors the init_cert.sh script in the docker container to support using custom SSL certificates.
I've added two env-vars,
NGINX_SSL_CERT
andNGINX_SSL_KEY
, which when set, will configure the nginx default.conf with the provided port and certificate paths. WhenLETSENCRYPT_DOMAIN
is set,NGINX_SSL_CERT
andNGINX_SSL_KEY
are ignored.I've also made it so that the dashboard port can be changed without providing certificates. This way, setting
NGINX_SSL_PORT
will change the nginx listen port. It may be worth considering changing the env-var name.This partially closes netbirdio/netbird#2242