[client] Fix/nil relayed address #4153
Merged
+90
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne status - handle the map in thread safe way - distinguish channel close and write operations
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes concurrency and nil pointer issues in the relay client code. The changes address a nil pointer panic that occurs when accessing the RelayAddr's String method and add proper synchronization to prevent race conditions in the peer subscription system.
- Adds mutex protection to prevent race conditions when accessing shared maps in PeersStateSubscription
- Refactors connection and handshake methods to properly handle RelayAddr lifecycle and prevent nil pointer access
- Improves channel handling to use buffered channels and proper signaling instead of relying on channel closure
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| relay/client/peer_subscription.go | Adds mutex synchronization, improves channel handling with buffered channels, and enhances error handling |
| relay/client/client.go | Refactors connection methods to return RelayAddr and adds proper instanceURL lifecycle management |
pappz
changed the title
lixmal
previously approved these changes
Jul 15, 2025
|
lixmal
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix nil pointer in Relay conn address
Meanwhile, we create a relayed net.Conn struct instance, it is possible to set the relayedURL to nil.
Issue ticket number and link
Stack
Checklist