[client] Fix bind exclusion routes #4154
Open
+75
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lixmal
force-pushed
the
fix-bind-exclusion-routes
branch
from
b7b44c1 to
d68acc8
Compare
lixmal
force-pushed
the
fix-bind-exclusion-routes
branch
from
d68acc8 to
f868fc5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bind exclusion routes in the client by improving network connection handling across different platforms. The changes move from Android-specific socket protection to a more generic listener-based approach and introduce platform-specific UDP connection wrapping.
- Replaces Android-specific control function with generic listener configuration
- Adds iOS-specific UDP connection wrapper implementation
- Introduces WrapUDPConn functionality for cross-platform connection handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| util/net/listener_listen_ios.go | Adds iOS-specific WrapUDPConn implementation that returns connections unchanged |
| util/net/listener_listen.go | Implements generic WrapUDPConn function and adds blank line formatting |
| client/iface/bind/ice_bind.go | Updates ICE bind to use wrapped UDP connections via nbnet.WrapUDPConn |
| client/iface/bind/control_android.go | Removes Android-specific socket protection control function |
| client/iface/bind/control.go | Adds generic control function initialization using listener configuration |
Comments suppressed due to low confidence (1)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist