Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digi PortServer TS 8/16 #2498

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Conversation

ravench
Copy link
Contributor

@ravench ravench commented Nov 13, 2024

No description provided.

@ravench ravench marked this pull request as ready for review November 13, 2024 13:33
@ravench ravench marked this pull request as draft November 13, 2024 14:02
@ravench
Copy link
Contributor Author

ravench commented Nov 13, 2024

I can't figure out why the test doesn't pass, as this file exists:

$ file elevation-images/Digi/digi-portserver-ts-16.jpg
elevation-images/Digi/digi-portserver-ts-16.jpg: JPEG image data, JFIF standard 1.01, resolution (DPI), density 72x72, segment length 16, Exif Standard: [TIFF image data, little-endian, direntries=7, orientation=upper-left, xresolution=98, yresolution=106, resolutionunit=2, software=GIMP 2.10.38, datetime=2024:11:13 14:14:17], progressive, precision 8, 847x78, components 3

@ravench ravench marked this pull request as ready for review November 13, 2024 14:24
@harryajc
Copy link
Collaborator

I can't figure out why the test doesn't pass, as this file exists:

$ file elevation-images/Digi/digi-portserver-ts-16.jpg
elevation-images/Digi/digi-portserver-ts-16.jpg: JPEG image data, JFIF standard 1.01, resolution (DPI), density 72x72, segment length 16, Exif Standard: [TIFF image data, little-endian, direntries=7, orientation=upper-left, xresolution=98, yresolution=106, resolutionunit=2, software=GIMP 2.10.38, datetime=2024:11:13 14:14:17], progressive, precision 8, 847x78, components 3

Its because the image file name is missing the .front. It should be digi-portserver-ts-16.front.jpg

@ravench
Copy link
Contributor Author

ravench commented Nov 14, 2024

Its because the image file name is missing the .front. It should be digi-portserver-ts-16.front.jpg

Thanks. I was too focused on the error message to notice.

Failed: device-types/Digi/portserver-ts-16.yaml has front_image set to True but no matching image found for device (['elevation-images/Digi/digi-portserver-ts-16.jpg'])

@harryajc harryajc merged commit 98f026b into netbox-community:master Nov 14, 2024
3 checks passed
@ravench ravench deleted the digi-ts-8-16 branch November 15, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants