Skip to content

Adding Quantum systems to netbox community devicetype-library #3069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lastb0isct
Copy link

This is to add some Quantum systems into the netbox catalog of devices.

@lastb0isct
Copy link
Author

Not sure what is causing the format issues here...

is_full_depth: true
airflow: front-to-rear
subdevice_role: parent
power-ports:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this device as hot swappable PSUs these should be modeled as module-bays then create the required PSUs as modules if they don't already exist.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should be:

module-bays:
  - name: '1'
    label: PSU Slot 1
    position: "1"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

is_full_depth: true
airflow: front-to-rear
subdevice_role: parent
power-ports:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this device as hot swappable PSUs these should be modeled as module-bays then create the required PSUs as modules if they don't already exist.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should be:

module-bays:

  • name: '1'
    label: PSU Slot 1
    position: "1"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

label: Controller Slot A
- name: B
label: Controller Slot B
interfaces:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these ports are on the controller rather than the chassis they shouldn't be modeled on the chassis device

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I put these on the controllers? Just put them under the device-bays & interfaces for each of them?

device-bays:
  - name: A
    label: Controller Slot A
    interfaces:
      - name: Ctl-A-FC-1
        type: 32gfc-sfp28

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you need to create a seperate device for the controller that has the interfaces defined.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand...thanks!

label: Controller Slot A
- name: B
label: Controller Slot B
interfaces:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these ports are on the controller rather than the chassis they shouldn't be modeled on the chassis device

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I put these on the controllers? Just put them under the device-bays & interfaces for each of them?

device-bays:

  • name: A
    label: Controller Slot A
    interfaces:
    • name: Ctl-A-FC-1
      type: 32gfc-sfp28

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you need to create a seperate device for the controller that has the interfaces defined.

console-ports:
- name: ServicePort
type: rj-45
power-ports:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing these are the controller devices, as these are child devices they don't have their own power ports.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are their own devices that have power and connect to the QXS devices via FC switches. But I would still need to change this to module-bays like you recommended, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, yes just convert them to module-bays

console-ports:
- name: ServicePort
type: rj-45
power-ports:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing these are the controller devices, as these are child devices they don't have their own power ports.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are their own devices that have power and connect to the QXS devices via FC switches. But I would still need to change this to module-bays like you recommended, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, yes just convert them to module-bays

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the cropping as images should have no white or blank space around the device.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the cropping as images should have no white or blank space around the device.

@harryajc harryajc added the status: revisions needed This issue requires additional information to be actionable label May 1, 2025
Copy link
Author

@lastb0isct lastb0isct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the edited/cropped images -- not sure how to change those in this draft review though.
QXS-484-back
QXS-424-back

label: Controller Slot A
- name: B
label: Controller Slot B
interfaces:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I put these on the controllers? Just put them under the device-bays & interfaces for each of them?

device-bays:
  - name: A
    label: Controller Slot A
    interfaces:
      - name: Ctl-A-FC-1
        type: 32gfc-sfp28

console-ports:
- name: ServicePort
type: rj-45
power-ports:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are their own devices that have power and connect to the QXS devices via FC switches. But I would still need to change this to module-bays like you recommended, right?

console-ports:
- name: ServicePort
type: rj-45
power-ports:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are their own devices that have power and connect to the QXS devices via FC switches. But I would still need to change this to module-bays like you recommended, right?

label: Controller Slot A
- name: B
label: Controller Slot B
interfaces:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would I put these on the controllers? Just put them under the device-bays & interfaces for each of them?

device-bays:

  • name: A
    label: Controller Slot A
    interfaces:
    • name: Ctl-A-FC-1
      type: 32gfc-sfp28

is_full_depth: true
airflow: front-to-rear
subdevice_role: parent
power-ports:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should be:

module-bays:

  • name: '1'
    label: PSU Slot 1
    position: "1"

module-bays & removed interfaces from this device.  Will create device child to be used in device-bays.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants