Skip to content

Conversation

@pheus
Copy link
Contributor

@pheus pheus commented Dec 31, 2025

Pull Request

Related Issue

Fixes #127 - [Feature]: List all interfaces an acl is applied to on the acl page

Note: This PR builds on / depends on the refactor work in #72.

New Behavior

This PR adds an ACL assignments view to the ACL (AccessList) detail page.

Users can now see a list of all interfaces the ACL is currently applied to (via the related ACLAssignment objects) directly on the ACL page, using a familiar list/table layout. An "Assign an ACL" button is also provided from the ACL view to streamline adding new assignments.

Contrast to Current Behavior

Currently, the ACL detail page does not provide a way to see where the ACL is applied. To answer “where is this ACL used?”, users have to navigate from the interface side (or search/filter assignments elsewhere).

With this PR, the ACL page includes an assignment tab/view that surfaces the related interface assignments in one place, making it much easier to audit usage and confirm the ACL’s scope.

Discussion: Benefits and Drawbacks

Benefits

  • Improves usability and visibility: you can immediately see which interfaces are affected by a given ACL.
  • Aligns with existing UI patterns (list/table views similar to other object relationships), so it feels consistent.
  • Reduces navigation overhead for common troubleshooting/auditing workflows.

Drawbacks / trade-offs

  • Adds another relationship list to render on the ACL detail page, which may introduce additional DB queries if not carefully prefetched/paginated (the view uses the existing assignment model/table and hides non-essential columns to keep it readable).
  • Depends on [Feature]: Assign a ACL to multiple devices  #72 due to the larger refactor (review/merge order matters).

Backwards compatibility

  • This change is additive from a data/model perspective.
  • Template/view changes are contained to the ACL detail UI and related assignment tab structure, so existing objects/assignments remain unchanged.

Changes to the Documentation

No documentation changes included yet.

If desired, I can add a short note to the docs/wiki describing the new Assignments tab on ACLs (and include a screenshot), once the UI direction is confirmed.

Proposed Release Note Entry

Add an ACL assignments view on the ACL (AccessList) detail page to show all interfaces the ACL is applied to.

Double Check

  • I have explained my PR according to the information in the comments
    or in a linked issue.
  • My PR targets the dev branch.

Introduces `AccessListACLAssignmentView` to display child ACLAssignments
for AccessLists. Hides unnecessary columns in the corresponding table
for improved clarity.

Closes netbox-community#127
Introduces new templates to include an "Assign an ACL" button and adjust
tab views for ACL. Updates template paths in views to align with the new
assignment tab structure for better clarity and usability.
@pheus
Copy link
Contributor Author

pheus commented Dec 31, 2025

The failure is caused by the actions/first-interaction v1 → v3 upgrade (see #296).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: List all interfaces an acl is applied to on the acl page

1 participant