[CI] Do not cancel concurrent CI jobs on main #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
commented
Jan 27, 2025
henrybear327
force-pushed
the
ci/remove-cancel-concurrent-jobs
branch
from
3be3a90 to
e0b8659
Compare
When we merge a PR into the main branch before the previously merged commit finishes, the CI jobs will be cancelled, which is not ideal as we would like to see if all commits merged into main can pass CI checks.
henrybear327
force-pushed
the
ci/remove-cancel-concurrent-jobs
branch
from
e0b8659 to
f0413c6
Compare
|
Hey team, Could we have this reviewed and merged when time permits :) This will reduce the CI failed email bombing when we merge dependabot PRs in quick succession! Thanks |
bruelea
approved these changes
Feb 12, 2025
|
This is somehow not working on main branch. I will fix this in a follow-up PR... |
henrybear327
added a commit
that referenced
this pull request
Feb 17, 2025
Our docker images being pushed to the GitHub registry relies on the CI runs against the main branch, so we need to ensure that the CI runs on main branch is always running without any hiccups. For some reason, #221 fails to address the cancellation on CI runs against main branch. Thus, in this PR, a change is introuduced to revert #160.
henrybear327
added a commit
that referenced
this pull request
Feb 17, 2025
For some reason, #221 fails to address the cancellation on CI runs against main branch. Our docker images being pushed to the GitHub registry relies on the CI runs against the main branch, so we need to ensure that the CI runs on main branch is always running without any hiccups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we merge a PR into the main branch before the previously merged commit finishes, the CI jobs will be cancelled (see https://github.com/netbox-community/netbox-operator/commits/main/), which is not ideal as we would like to see if all commits merged into the main branch can pass CI checks.