Fixes #18594: asn_count sort in Sites list #18634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bctiemann
requested changes
Feb 14, 2025
|
@jnovinger could you please apply the same fix for the |
Thanks @bctiemann for point this out!
Fix committed, looking to see what testing opportunities we might have. |
Looks like we don't currently have any tests for various table subclasses, outside of one small example. While I think it's worthwhile to add tests, seems like it might be outside the scope for this ticket, especially since the change in behavior is not using an in-house customization. @jeremystretch , thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18594 - Site list can now be sorted by the
asn_countcolumnChanges:
asn_countannotationaccessorargument forasn_countcolumn