Fixes #18585: filtering circuits by location #18641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a related issue where selected filter is not shown in the filter form. Changes: - Adds `CircuitFilterSet.location_id` field to enable filtering with incoming GET params - Adds `CirciotFilterForm.location_id` field to enable filtering from list form - Adds `location_id` to the Location fieldset on `CircuitFilterForm`
jeremystretch
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Looks good @jnovinger, thanks! One ask: Could you add a simple test for the new filter under CircuitTestCase? You'll just need to create some Location instances under setUpTestData() and assign circuits to them, then essentially replicate the logic from test_site() method for location_id.
Test added! Thanks for the catch. |
jnovinger
deleted the
18585-filtering-circuits-by-location-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18585 - filtering circuits by location
This also fixes a related issue where selected filter is not shown in the filter form.
Changes:
CircuitFilterSet.location_idfield to enable filtering with incoming GET paramsCircuitFilterForm.location_idfield to enable filtering from list formlocation_idto the Location fieldset onCircuitFilterForm