Closes #18138: Add advanced object selector for custom field object and multi-object inputs#18830
Merged
arthanson merged 2 commits intonetbox-community:mainfrom Mar 26, 2025
Merged
Conversation
jnovinger
requested review from
a team and
bctiemann
and removed request for
a team
Contributor
|
@atownson I'm getting this error when I try to set up a custom field with object or multiobject type and then use the selector: 
I wouldn't be surprised if it's an issue on my end, but could you please check in case it's a bug? |
Collaborator
|
Working for me: |
arthanson
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #18138
The approach here was to hard-code the
selector=Trueargument for the object and multi-object inputs, thus always rendering the advanced object selector button. The advantage to this approach is that it does not require an additional attribute on theCustomFieldmodel or any logic to show/hide the input for such an attribute on the create form.