Closes #16224 GraphQL Pagination#18903
Merged
Conversation
arthanson
requested review from
a team and
jnovinger
and removed request for
a team
jnovinger
requested changes
Mar 18, 2025
Member
jnovinger
left a comment
jnovinger
left a comment
There was a problem hiding this comment.
I would not have guessed that you'd be forced to add the pagination argument to every type class.
There are a couple of patterns to my comments/questions:
- In several type definitions, there's an extra empty line following the
paginationparameter. Those should be removed. I started commenting them all and that just felt like overkill. - There are several type definitions I saw that did not have pagination enabled and I asked why inline. Those seemed to be mostly in the
dcimandipampackages.
However, there were two that I wasn't sure about, because they seem like they might be base definitions: netbox.graphql.types.ContentTypeType and netbox.graphql.types.ObjectTypeType. Is there a good reason not to paginate those?
jnovinger
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16224