Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes: #11507 - Show Prefixes Aggregate and RIR on API view #18935

Draft
wants to merge 1 commit into
base: feature
Choose a base branch
from

Conversation

DanSheps
Copy link
Member

Closes: #11507 - Show Prefixes Aggregate and RIR on API view

  • Add rir property method to model
  • Add aggregate property method to model
  • Add rir attribute to serializer
  • Add aggregate attribute to serializer
  • Add test for both rir and aggregate fields on API

* Add `rir` property method to model
* Add `aggregate` property method to model
* Add `rir` attribute to serializer
* Add `aggregate` attribute to serializer
* Add test for both rir and aggregate fields on API
@DanSheps DanSheps added this to the v4.3 milestone Mar 18, 2025
@DanSheps DanSheps self-assigned this Mar 18, 2025
@DanSheps DanSheps marked this pull request as draft March 18, 2025 02:54
@DanSheps
Copy link
Member Author

Thinking about this, I think there are a few questions to ask before this can be reviewed:

  • Which is the better way to go: method property vs SerializerMethodField?
  • Would this benefit from being a cached field on the prefix model?

@DanSheps DanSheps linked an issue Mar 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Aggregate and RIR on Prefixes in API
1 participant