Virtual Machine Resources Use Decimal MB/GB Instead of Binary MiB/GiB#21210
Virtual Machine Resources Use Decimal MB/GB Instead of Binary MiB/GiB#21210kakathian wants to merge 2 commits intonetbox-community:mainfrom
Conversation
|
@kakathian, our contribution process specifically calls for not working on issues or filing PRs until an issue has been assigned to you. In order for us to assign it to you, you must comment on the original issue indicating you would like to work on it. |
|
@kakathian , can you please address the CI failures? |
b77a2d6 to
99110cd
Compare
|
Thanks. This PR is ready for reviews |
|
Hi @kakathian, looking at this PR it appears that all it does it change the labeling in the UI to reflect a presumption that the stored values are binary (MiB/GiB). It doesn't seem to take into account the setting of The proposal in the issue was meant to cover different users' needs by flexibly adapting to whether they are using base-10 or base-2 units, or else by adopting a comprehensive, system-wide enforcement of a standard storage unit and then reflecting the chosen display unit at the UI level. |
bctiemann
left a comment
There was a problem hiding this comment.
Please see general comments.
Fixes: #21095
This change would primarily affect display and input handling in the VM resources UI, without changing the underlying numeric values unless binary units are adopted.