Skip to content

Virtual Machine Resources Use Decimal MB/GB Instead of Binary MiB/GiB#21210

Closed
kakathian wants to merge 2 commits intonetbox-community:mainfrom
kakathian:issue-21095
Closed

Virtual Machine Resources Use Decimal MB/GB Instead of Binary MiB/GiB#21210
kakathian wants to merge 2 commits intonetbox-community:mainfrom
kakathian:issue-21095

Conversation

@kakathian
Copy link

Fixes: #21095

This change would primarily affect display and input handling in the VM resources UI, without changing the underlying numeric values unless binary units are adopted.

@kakathian kakathian marked this pull request as ready for review January 17, 2026 19:46
@jnovinger
Copy link
Member

@kakathian, our contribution process specifically calls for not working on issues or filing PRs until an issue has been assigned to you. In order for us to assign it to you, you must comment on the original issue indicating you would like to work on it.

@jnovinger jnovinger marked this pull request as draft January 26, 2026 21:20
@jeremystretch jeremystretch marked this pull request as ready for review January 31, 2026 00:41
@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team January 31, 2026 00:41
@jnovinger
Copy link
Member

@kakathian , can you please address the CI failures?

@kakathian
Copy link
Author

Thanks. This PR is ready for reviews

@bctiemann
Copy link
Contributor

Hi @kakathian, looking at this PR it appears that all it does it change the labeling in the UI to reflect a presumption that the stored values are binary (MiB/GiB). It doesn't seem to take into account the setting of DISK_BASE_UNIT/RAM_BASE_UNIT (which might be set to something else, and indeed by default are set to base 10, i.e. MB/GB or 1000 MB = 1 GB).

The proposal in the issue was meant to cover different users' needs by flexibly adapting to whether they are using base-10 or base-2 units, or else by adopting a comprehensive, system-wide enforcement of a standard storage unit and then reflecting the chosen display unit at the UI level.

Copy link
Contributor

@bctiemann bctiemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see general comments.

@kakathian kakathian closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtual Machine Resources Use Decimal MB/GB Instead of Binary MiB/GiB, Causing Memory Mismatch

3 participants