feat: prevent duplicate component creation from templates #143
Merged
mfiedorowicz merged 4 commits intodevelopfrom Dec 2, 2025
Merged
feat: prevent duplicate component creation from templates #143mfiedorowicz merged 4 commits intodevelopfrom
mfiedorowicz merged 4 commits intodevelopfrom
Conversation
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
jajeffries
approved these changes
Dec 1, 2025
Contributor
jajeffries
left a comment
There was a problem hiding this comment.
Overall looks good - couple of minor suggestions but happy for it to go in as is
…rove readability Signed-off-by: Michal Fiedorowicz <[email protected]>
…ting instances Signed-off-by: Michal Fiedorowicz <[email protected]>
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
leoparente
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of auto-created component objects (such as interfaces and module bays) to prevent duplicate creation when applying changes through the API. It introduces logic to detect and update existing components that were instantiated from templates, ensuring that incoming changes reuse and update these objects rather than creating new duplicates. The changes are validated with new tests that verify correct reuse and updating of components.
Component Deduplication Logic:
_apply_changeinnetbox_diode_plugin/api/applier.pyto check for existing auto-created components (likedcim.interface,dcim.modulebay, etc.) before creating new ones, and to update them if found instead of creating duplicates.Testing Improvements:
test_module_bay_from_template_no_duplicateandtest_interface_from_template_no_duplicatetonetbox_diode_plugin/tests/test_api_apply_change_set.pyto verify that module bays and interfaces created from templates are reused and updated, not duplicated, when ingested via API changes.Operational Tuning:
start_periodfor the NetBox service indocker/docker-compose.yamlfrom 60s to 180s to allow more time for startup before healthchecks begin.