-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NAE-1946] Remote file connector to S3 #243
Conversation
- partial implementation of minio integration
- partial implementation of minio integration
- fix uploading to minio by defining minimum part size
- added remote file list field implementation
- some exception changes
- some exception changes
- extract StorageType type to enum
- update some exception handling
- update conditioning on some minio services
- update version
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
1 similar comment
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- update FileListFieldTest
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- update FileFieldTest - extract constant in FileListFieldTest
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- fix semicolon
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- minio service
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- minio service
- remove redundant comment
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
- fix new init test
- added todo
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
# Conflicts: # src/main/java/com/netgrif/application/engine/workflow/service/DataService.java # src/main/java/com/netgrif/application/engine/workflow/service/interfaces/IDataService.java
src/main/java/com/netgrif/application/engine/files/minio/MinioStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Show resolved
Hide resolved
src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FileListField.groovy
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/StorageResolverService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/StorageType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/local/LocalStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/local/LocalStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/StorageType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/local/LocalStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/local/LocalStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/minio/MinioStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/minio/MinioStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/minio/MinioStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/minio/MinioStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/workflow/service/DataService.java
Show resolved
Hide resolved
src/test/groovy/com/netgrif/application/engine/workflow/NewInitTest.groovy
Show resolved
Hide resolved
- refactor after PR comments
- fix typo
- updated according to new requirements
…all cases - corrected acording to PR
- updated minio version
- updated according to product meeting
- revert schema
- updated tests
src/main/java/com/netgrif/application/engine/files/local/LocalStorageService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/netgrif/application/engine/files/minio/MinIoStorageService.java
Outdated
Show resolved
Hide resolved
- updated according to PR
Test fails due to unmerged PR netgrif/petriflow#26. |
Description
Implemented minio remote storage
Implements NAE-1946
Dependencies
No new dependencies were introduced
Third party dependencies
Blocking Pull requests
How Has Been This Tested?
Test Configuration
Checklist: