[NAE-1998] Implement transactions for events #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- init transaction implementation
- move and update NaeTransaction - rework transaction execution in ActionDelegate - add TransactionTest file with resource file
- move and update TransactionTest
- implement transaction timeout in NaeTransaction - rename ActionDelegate.transaction parameter
- update return type of ActionDelegate.transaction - fix transaction timeout in ActionRunner - refactor elastic indexing of case, task and petriNet - implement ElasticPetriNetService.findAllByIdentifier - rework PetriNetEventHandler, CaseEventHandler, TaskEventHandler - update and implement some tests in TransactionTest
- update transaction error logging in ActionDelegate - implement new tests in TransactionTest
- implement error propagation into rollback closure in NaeTransaction - implement test for error propagation
- add javadoc - refactor ActionDelegate.throwIfCallBackFailed - optimize imports
- change mongo configuration to replica set
- fix mongo event handlers to work with empty documents
- fix access modifiers in ActionRunner and MongoConfig
Retoocs
requested review from
tuplle,
camperko,
Kovy95,
SamuelPalaj,
MartinSiran and
mazarijuraj
- edit github pipeline
- edit github pipeline
- edit github pipeline
- edit github pipeline
- edit github pipeline
- edit github pipeline
machacjozef
removed request for
tuplle,
camperko,
Kovy95,
SamuelPalaj and
MartinSiran
- optimize DataService.getData
- optimize DataService.setData
- implement and use ActionDelegate.deleteCase
- optimize PetriNetService.importPetriNet - fix some warnings
- fix WorkflowAuthorizationServiceTest
- fixes according to unit tests
- change builder() to with()
- change builder() to with() - remove disabled test
- add javadoc
# Conflicts: # src/test/groovy/com/netgrif/application/engine/auth/WorkflowAuthorizationServiceTest.groovy # src/test/groovy/com/netgrif/application/engine/export/service/ExportServiceTest.groovy # src/test/groovy/com/netgrif/application/engine/petrinet/domain/EventTest.groovy # src/test/resources/change_caseref_value_action_test.xml
- fix tests - update application-test.properties
Retoocs
requested review from
tuplle,
camperko,
Kovy95,
SamuelPalaj,
MartinSiran and
mazarijuraj
- fix TransactionTest.testBasicTransactionWithFailure - implement transactional option in DataService.setData - implement new tests in DataServiceTest
- update DataServiceTest
- make DataService.getData optionally transactional - add javadoc for DataService.setData - optimize DataService.setData - update DataServiceTest
- make WorkflowService.createCase optionally transactional - implement new tests in WorkflowServiceTest - fix id of create_case_locale.xml
- make WorkflowService.deleteCase optionally transactional - implement new tests in WorkflowServiceTest
- optimize transactions in API
- make TaskService.assignTask optionally transactional - make TaskService.finishTask optionally transactional - make TaskService.cancelTask optionally transactional - implement new tests in TaskServiceTest
- make PetriNetService.importPetriNet optionally transactional - fix handling non-existing petriNets in PetriNetService.findByImportId - implement new tests in PetriNetServiceTest
- refactor PetriNetService.deletePetriNet - make PetriNetService.deletePetriNet optionally transactional - optimize NaeTransaction build up
- implement and apply NaeTransactionProperties with default values - fix NaeTransactionBuilder.forceCreation - add and use application-test-transaction.properties
- implement performance test in TransactionTest - add javadoc in TaskDataSets
- add test net from builder with some changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement transactions for Petriflow actions. Optimized some services
Implements NAE-1998
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually and with unit tests. Test file: TransactionTest
Test Configuration
Checklist: