chore(freepbx): import nethserver-phonebook-mysql #516
+1,183
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amygos
force-pushed
the
nethserver-phonebook-mysql
branch
from
795c3b1 to
d390cb7
Compare
Stell0
approved these changes
Jul 22, 2025
Vendoring the `ns8` branch, starting from nethesis/nethserver-phonebook-mysql@e37e63f
Amygos
force-pushed
the
nethserver-phonebook-mysql
branch
from
215157c to
28389e5
Compare
unixodbc files are overwritten on container restart, with this library is possible to use pdo dblib like in business_nts example https://github.com/nethesis/ns8-nethvoice/blob/b0c15755fd627659c75541b232464ccf4a297cff/freepbx/usr/share/phonebooks/samples/business_nts.php#L6
Amygos
force-pushed
the
nethserver-phonebook-mysql
branch
from
28389e5 to
476aab9
Compare
Remove gamma_enterprise.php sample script as it cannot be tested at this time. Consider re-adding in the future if testing becomes possible.
Stell0
approved these changes
Jul 22, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR imports the nethserver-phonebook-mysql package into the FreePBX codebase, replacing a remote download with vendored files. The change transitions from downloading phonebook scripts at build time to including them directly in the repository.
- Vendors the phonebook integration scripts from the
ns8branch of nethserver-phonebook-mysql - Adds support for MS SQL Server database connectivity through FreeTDS
- Includes sample integration scripts for various CRM systems (VTiger, VTE, Business NTS, WebRecall)
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| freepbx/Containerfile | Adds FreeTDS dependencies and replaces remote download with local copy |
| freepbx/usr/share/phonebooks/phonebook-import | Main Python script for importing contacts from various database sources |
| freepbx/usr/share/phonebooks/phonebook | Shell script orchestrating phonebook synchronization |
| freepbx/usr/share/phonebooks/*.php | Core PHP scripts for exporting/cleaning phonebook data |
| freepbx/usr/share/phonebooks/samples/*.php | Sample integration scripts for external CRM systems |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendoring the
ns8branch, starting from nethesis/nethserver-phonebook-mysql@e37e63fNethServer/dev#7564