Skip to content

fix: notify activity should not be called for the HEAD requests #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

VitaliyR
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Some requests might come as HEAD and spamming them might create a lot of activity calls - this PR prevents it.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@VitaliyR VitaliyR requested a review from a team as a code owner June 23, 2025 19:02
@VitaliyR VitaliyR requested review from cmparsons and removed request for cmparsons June 23, 2025 19:02
Copy link

github-actions bot commented Jun 23, 2025

📊 Benchmark results

Comparing with 9b16f4f

  • Dependency count: 1,105 (no change)
  • Package size: 277 MB (no change)
  • Number of ts-expect-error directives: 399 (no change)

@VitaliyR VitaliyR force-pushed the vitaliir/fix-notify-activity branch from e1eb93d to 555480d Compare June 23, 2025 19:08
@VitaliyR VitaliyR merged commit 9afc84b into main Jun 23, 2025
62 of 65 checks passed
@VitaliyR VitaliyR deleted the vitaliir/fix-notify-activity branch June 23, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants