Skip to content

fix: notify activity was called for internal endpoints #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

VitaliyR
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Found another issue where liveness check was triggering notify activity, which made the preview server never auto shutdown


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@VitaliyR VitaliyR requested a review from a team as a code owner June 24, 2025 11:58
Copy link

📊 Benchmark results

Comparing with 7ab8f6c

  • Dependency count: 1,105 (no change)
  • Package size: 277 MB ⬇️ 0.00% decrease vs. 7ab8f6c
  • Number of ts-expect-error directives: 399 (no change)

@VitaliyR VitaliyR requested a review from davbree June 24, 2025 12:35
@VitaliyR VitaliyR merged commit b05416a into main Jun 24, 2025
53 of 54 checks passed
@VitaliyR VitaliyR deleted the vitaliir/fix-notify-activity branch June 24, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants