fix: providing cwd matching the root dir and filter option conflicted… #7366
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preventing functions to be discovered
cmparsons
reviewed
Jun 25, 2025
|
|
||
| // if cwd matches process.cwd, act like cwd wasn't provided | ||
| if (resolvedCwd === processCwd) { | ||
| delete flags.cwd |
There was a problem hiding this comment.
Is this the main change? I'm kinda confused on what behavior has changed because it seems like we're still resolving to the cwd from the flag or process.cwd()
There was a problem hiding this comment.
Down the process it is being check
cli/src/commands/base-command.ts
Line 544 in 28252a8
cmparsons
approved these changes
Jun 25, 2025
|
Confirmed fix in RC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… preventing functions to be discovered
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes EX_184
Preview Server always provides a
cwdmatching the root dir. But since it was provided - thefilteroption started to conflict, so edge function dir never set hence functions are never "discovered".For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)