feat: throw error on deploy command if build fails and user has --json option #7367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with d81b990
|
…t-error-code-with-the-json-flag
serhalp
approved these changes
Jun 26, 2025
| cwd: builder.directory, | ||
| env: { NETLIFY_SITE_ID: context.siteId }, | ||
| }), | ||
| ).rejects.toThrow('Error while running build') |
There was a problem hiding this comment.
do we expect the output to be json on failures or no?
There was a problem hiding this comment.
nope don't do that anywhere else
…t-error-code-with-the-json-flag
…t-error-code-with-the-json-flag
sarahetter
deleted the
sarahetter/cpla-2772-cli-not-throwing-an-exit-error-code-with-the-json-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a build fails when a user runs
netlify deploy --jsonit currently fails silently. Behaviour can be seen by running:on a project that has
exit 1as its build command.This PR changes that so we now throw an error like elsewhere in the deploy command, regardless of the
--jsonoption