NETOBSERV-1616: collect flow metric object from netobserv ns #13
Conversation
|
@msherif1234: This pull request references NETOBSERV-1616 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
collection-scripts/gather_resources
Outdated
| oc adm inspect --dest-dir "${BASE_COLLECTION_PATH}" "${CRD}/${obj}" | ||
| oc adm inspect --dest-dir "${BASE_COLLECTION_PATH}" "${FC_CRD}/${fc_obj}" | ||
| if [ -n "${metric_obj}" ]; then | ||
| oc adm inspect --dest-dir "${BASE_COLLECTION_PATH}" -n "${fc_ns}" "${METRIC_CRD}/${metric_obj}" |
There was a problem hiding this comment.
| oc adm inspect --dest-dir "${BASE_COLLECTION_PATH}" -n "${fc_ns}" "${METRIC_CRD}/${metric_obj}" | |
| oc adm inspect --dest-dir "${BASE_COLLECTION_PATH}" -n "${fc_ns}" "${METRIC_CRD} ${metric_obj}" |
otherwise it would fail if you had more than one metrics object
Signed-off-by: Mohamed Mahmoud <[email protected]>
msherif1234
force-pushed
the
flowmetrics
branch
from
468c163
to
d4c9c6c
Compare
|
@memodi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Release note: