Skip to content

NETOBSERV-2221: follow-up: make default metrics, show % ipsec traffic [1.9 backport] #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

jotak
Copy link
Member

@jotak jotak commented Jun 3, 2025

Backport of #1573

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 3, 2025

@jotak: This pull request references NETOBSERV-2221 which is a valid jira issue.

In response to this:

Backport of #1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign msherif1234 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.72%. Comparing base (a7e6266) to head (b1c722d).
Report is 1 commits behind head on release-1.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #1594      +/-   ##
===============================================
+ Coverage        62.63%   62.72%   +0.08%     
===============================================
  Files               76       76              
  Lines            11573    11598      +25     
===============================================
+ Hits              7249     7275      +26     
+ Misses            3858     3857       -1     
  Partials           466      466              
Flag Coverage Δ
unittests 62.72% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apis/flowcollector/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
apis/flowcollector/v1beta2/flowcollector_types.go 100.00% <ø> (ø)
pkg/metrics/predefined_charts.go 99.68% <100.00%> (+0.01%) ⬆️
pkg/metrics/predefined_metrics.go 95.03% <100.00%> (+0.23%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@memodi
Copy link
Member

memodi commented Jun 3, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 3, 2025
Copy link

github-actions bot commented Jun 3, 2025

New images:

  • quay.io/netobserv/network-observability-operator:c0e082c
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-c0e082c
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-c0e082c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:c0e082c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-c0e082c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-c0e082c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@memodi
Copy link
Member

memodi commented Jun 3, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jun 3, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 3, 2025

@jotak: This pull request references NETOBSERV-2221 which is a valid jira issue.

In response to this:

Backport of #1573

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak merged commit 43e75f8 into netobserv:release-1.9 Jun 4, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants