Skip to content

Comments

NETOBSERV-2360 Loki dev mode#1801

Merged
jpinsonneau merged 7 commits intomainfrom
loki-dev
Jan 20, 2026
Merged

NETOBSERV-2360 Loki dev mode#1801
jpinsonneau merged 7 commits intomainfrom
loki-dev

Conversation

@jpinsonneau
Copy link
Member

@jpinsonneau jpinsonneau commented Jul 28, 2025

Description

Implement a new loki mode Dev that deploy the zero click loki.

Also took the opportunity to update the config to rely on latest release using tsdb.

TODOs:

  • move that new mode inside monolithic config
  • expose loki uri in CSV
    • that will allow us to change it downstream to registry.redhat.io/openshift-logging/logging-loki-rhel9:v3.4.3 without effort
    • config.file is exposed as container ARG to support downstream image

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau requested review from jotak and stleerh July 28, 2025 10:08
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 30, 2025
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:07f9391
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-07f9391
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-07f9391

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:07f9391 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-07f9391

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-07f9391
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 30, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 30, 2025
@jpinsonneau
Copy link
Member Author

Updated bundle

@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:0492b4c
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-0492b4c
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-0492b4c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:0492b4c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-0492b4c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-0492b4c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@jpinsonneau jpinsonneau changed the title Loki dev mode NETOBSERV-2360 Loki dev mode Aug 1, 2025
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Aug 5, 2025
@jpinsonneau jpinsonneau added the needs-review Tells that the PR needs a review label Aug 7, 2025
@memodi
Copy link
Member

memodi commented Sep 12, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 12, 2025
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:7ea9054
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-7ea9054
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-7ea9054

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:7ea9054 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-7ea9054

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-7ea9054
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 25, 2025
@jpinsonneau
Copy link
Member Author

Rebased without changes

@mffiedler
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 11, 2025
@Amoghrd Amoghrd removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 11, 2025
@Amoghrd
Copy link
Member

Amoghrd commented Dec 11, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 11, 2025
@memodi
Copy link
Member

memodi commented Jan 15, 2026

@memodi I don't see the PVC being removed in the CI logs anymore and there is no error in FLP.

@jpinsonneau unfortunately, no. I tried to look into must-gather from the run and FLP pod logs, I couldn't find any smoking guns.

@memodi
Copy link
Member

memodi commented Jan 15, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 15, 2026
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:ce68c51
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-ce68c51
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-ce68c51

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:ce68c51 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-ce68c51

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-ce68c51
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@memodi
Copy link
Member

memodi commented Jan 15, 2026

@jpinsonneau it's because you have new env var in the bundle RELATED_IMAGE_DEMO_LOKI and in CI we're patching DOWNSTREAM_DEPLOYMENT based on the the index https://github.com/openshift/release/blob/master/ci-operator/config/netobserv/network-observability-operator/netobserv-network-observability-operator-main.yaml#L91C170-L91C173 , I'll update the CI to patch based on env var name instead.

@memodi
Copy link
Member

memodi commented Jan 15, 2026

updating tests here openshift/release#73590

@jpinsonneau
Copy link
Member Author

@jpinsonneau it's because you have new env var in the bundle RELATED_IMAGE_DEMO_LOKI and in CI we're patching DOWNSTREAM_DEPLOYMENT based on the the index https://github.com/openshift/release/blob/master/ci-operator/config/netobserv/network-observability-operator/netobserv-network-observability-operator-main.yaml#L91C170-L91C173 , I'll update the CI to patch based on env var name instead.

Oh ok thanks for finding that. But why the controller logs seems fine then ? I would have expected errors there 🤔
I'm probably missing something !

@memodi
Copy link
Member

memodi commented Jan 16, 2026

Oh ok thanks for finding that. But why the controller logs seems fine then ? I would have expected errors there 🤔
I'm probably missing something !

no, because it patched the var at index 4, it actually ended up patching RELATED_IMAGE_DEMO_LOKI env var:

    - name: RELATED_IMAGE_DEMO_LOKI
      value: "true"
    - name: DOWNSTREAM_DEPLOYMENT
      value: "false"

@jpinsonneau
Copy link
Member Author

/test e2e-operator

@jpinsonneau
Copy link
Member Author

Tests are now passing 🥳

@Amoghrd
Copy link
Member

Amoghrd commented Jan 19, 2026

@jpinsonneau Could you rebase the PR to get the alertManager fix?

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2026
@jpinsonneau
Copy link
Member Author

@jpinsonneau Could you rebase the PR to get the alertManager fix?

Rebased without changes

@Amoghrd
Copy link
Member

Amoghrd commented Jan 20, 2026

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 20, 2026
@github-actions
Copy link

New images:

  • quay.io/netobserv/network-observability-operator:3765447
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-3765447
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-3765447

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:3765447 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-3765447

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-3765447
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@Amoghrd
Copy link
Member

Amoghrd commented Jan 20, 2026

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jan 20, 2026
@jpinsonneau
Copy link
Member Author

Thanks @Amoghrd !

@jpinsonneau jpinsonneau merged commit 99f2198 into main Jan 20, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants