-
Notifications
You must be signed in to change notification settings - Fork 32
NETOBSERV-1786: Add support to build file based catalog #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@OlivierCazade: This pull request references NETOBSERV-1786 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 65.97% 66.17% +0.19%
==========================================
Files 72 74 +2
Lines 8383 8561 +178
==========================================
+ Hits 5531 5665 +134
- Misses 2454 2498 +44
Partials 398 398
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -429,6 +437,14 @@ bundle-build: ## Build the bundle image. | |||
bundle-push: ## Push the bundle image. | |||
$(OCI_BIN) push ${BUNDLE_IMAGE}; | |||
|
|||
.PHONY: file-based-catalog-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious why did u added those two new targets since konflux pipeline will use the containerfile directly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently have target to build a regular catalog, but if I understand correctly at some point this catalog will be replaced by file based catalog.
I wanted to introduce the new targets without replacing the old ones for now.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This catalog will replace the catalog we currently use, for now, we have Makefile target for both.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.